Update description in "Using one Layout for .md, .mdx, and .astro" section.#4244
Merged
Conversation
Update description in "Using one Layout for .md, .mdx, and .astro" section. Considering the code first tries to get the title from `frontmatter`, the order in the paragraph should be: the layout will display the page title either from a frontmatter YAML title property or from an Astro component passing a title attribute This more accurately represents the actual execution flow of the code: 1. First try to get the title from `frontmatter` 2. If not exists, then use the title attribute from component By swapping the order in the paragraph, it can be more consistent with the code behavior and improve readability.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
approved these changes
Aug 17, 2023
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Approved for merge queue! Thanks for this thoughtful edit, @codersjj !
sarah11918
added
the
improve or update documentation
yanthomasdev
approved these changes
Aug 17, 2023
Member
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM! Thanks @codersjj 🙌
yanthomasdev
added a commit
that referenced
this pull request
Aug 18, 2023
* i18n(zh-cn): Update `core-concepts/layout.mdx` * chore: fix the broken link * feat: update from #4244 --------- Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Considering the code first tries to get the
titlefromfrontmatter, the order in the paragraph should be:the layout will display the page title either from a frontmatter YAML
titleproperty or from an Astro component passing atitleattributeThis more accurately represents the actual execution flow of the code:
titlefromfrontmattertitleattribute from componentBy swapping the order in the paragraph, it can be more consistent with the code behavior and improve readability.