Skip to content

i18n(ja): Update images.mdx#4521

Merged
yanthomasdev merged 5 commits into
withastro:mainfrom
morinokami:i18n-ja-images-0
Sep 4, 2023
Merged

i18n(ja): Update images.mdx#4521
yanthomasdev merged 5 commits into
withastro:mainfrom
morinokami:i18n-ja-images-0

Conversation

@morinokami
Copy link
Copy Markdown
Member

What kind of changes does this PR include?

  • New or updated content
  • Translated content

Description

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 2, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9c35849
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64f6031b5466a1000824d579
😎 Deploy Preview https://deploy-preview-4521--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 2, 2023
Copy link
Copy Markdown
Contributor

@kyosuke kyosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami レビューしました。1つコメントしてます。ご確認ください。

Comment thread src/content/docs/ja/guides/images.mdx
Copy link
Copy Markdown
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

レビューさせて頂きました
2点確認お願いします

```bash
pnpm install sharp
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:::

noteの終了タグがないみたいです

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます!こちら kyosuke さんが同じ指摘をされており、上にあったためそちらをコミットしました🙏

Comment thread src/content/docs/ja/guides/images.mdx Outdated
morinokami and others added 2 commits September 3, 2023 22:14
Co-authored-by: Kyosuke Nakamura <kyosuke@users.noreply.github.com>
Co-authored-by: ryu <114303361+ryuapp@users.noreply.github.com>
@morinokami morinokami requested review from kyosuke and ryuapp September 3, 2023 14:03
Copy link
Copy Markdown
Contributor

@kyosuke kyosuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏
LGTM

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work peeps 🚀

@yanthomasdev yanthomasdev merged commit 9c55b1a into withastro:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants