Skip to content

i18n(zh-CN): add translation guides#4694

Merged
yanthomasdev merged 4 commits into
withastro:mainfrom
Genteure:zh-cn/guide
Nov 18, 2023
Merged

i18n(zh-CN): add translation guides#4694
yanthomasdev merged 4 commits into
withastro:mainfrom
Genteure:zh-cn/guide

Conversation

@Genteure
Copy link
Copy Markdown
Contributor

@Genteure Genteure commented Sep 14, 2023 •
edited
Loading

What kind of changes does this PR include?

  • Something else!

Description

Add translation guides for zh-cn.

@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 14, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 126a422
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6550c5abd39d0f0008edf06e
😎 Deploy Preview https://deploy-preview-4694--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 14, 2023
@Genteure Genteure force-pushed the zh-cn/guide branch 2 times, most recently from dc2ed8d to 41e1860 Compare September 15, 2023 15:35
This was referenced Sep 17, 2023
Merged
Merged
@Genteure Genteure closed this Oct 6, 2023
@Genteure Genteure deleted the zh-cn/guide branch October 6, 2023 12:06
@Genteure Genteure restored the zh-cn/guide branch October 6, 2023 12:08
@Genteure Genteure reopened this Oct 6, 2023
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Nov 9, 2023

Hi @Genteure ! I love that you have decided to make your own translation guide!

Instead of a draft PR, merging something smaller to start, that can be PRd and improved upon might be more helpful. I would be happy to approve merging something and then you can continue to add/improve it! Please let a maintainer know when you feel ready to do this by undrafting the PR , and we will merge it! 🙌

@Genteure
Copy link
Copy Markdown
Contributor Author

Genteure commented Nov 9, 2023

Hi @sarah11918. Sorry this PR has been left aside for some time, I'll cleanup and finish this PR in the next few days.

@Genteure Genteure marked this pull request as ready for review November 12, 2023 12:21
@Genteure
Copy link
Copy Markdown
Contributor Author

Genteure commented Nov 12, 2023

This PR is ready for review and merge.

cc @100gle @liruifengv

100gle
100gle approved these changes Nov 18, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@100gle 100gle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work! 👍

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 18, 2023 0:59am

yanthomasdev
yanthomasdev approved these changes Nov 18, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙌

@yanthomasdev yanthomasdev merged commit b1e0ec1 into withastro:main Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

+1 more reviewer

@100gle 100gle 100gle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Genteure @sarah11918 @100gle @yanthomasdev