Fix integration script for non-core adapters#4741
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
From discussion in Discord, the outstanding thing here is to figure out what to do about the pages that are now excluded. Some options:
|
|
Note to us to merge this when the affected repositories have been moved, and we'll make any necessary docs changes to content on our end at that time. (E.g. if there is no page remaining to pull in, our content will simply not update and continue to show what's current, so we'll have to either remove manually on our end, or update manually to show a redirect etc.) |
ae866f0 to
4584e1e
Compare
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
left a comment
There was a problem hiding this comment.
I'm approving the page text! This should wait for Chris to confirm some page generation questions I had.
| The Deno adapter allows Astro to deploy your SSR site to Deno targets including Deno Deploy. | ||
|
|
||
| [astro-integration]: /en/guides/integrations-guide/ | ||
| The Deno adapter was previously maintained by Astro but now is maintained by Deno directly. Usage is now documented [in the Deno adapter repository](https://github.com/denoland/deno-astro-adapter). |
There was a problem hiding this comment.
I’d be in favour of minimal migration docs here once we know the new package name. Something along the lines of:
- Uninstall
@astrojs/deno - Install
deno-astro-adapter(or whatever it ends up being called) - Update the import statement in
astro.config.mjsto use the new package:- import deno from '@astrojs/deno'; + import deno from 'deno-astro-adapter';
But I can understand if we’re reticent to provide any guidance or want to keep that somewhere else.
There was a problem hiding this comment.
I do like this! Let's do it!
There was a problem hiding this comment.
I think we're going to want to merge this before they have released a new adapter (which we don't know when is going to happen). So would it be ok to go with this for now and update the guidance once that's out?
|
The home for Netlify might be changing, so holding off on this one for now, putting back as a draft. |
|
Ok, this is ready for review again. This is cleaned up so that only Deno is removed from generation. Netlify is now maintained in https://github.com/withastro/adapters/tree/main/packages/netlify and the plan is that other adapters will be moved over. I'll update the script again when those are moved over. |
There was a problem hiding this comment.
Thanks @matthewp! Left a couple of notes.
Also underlining that these changes mean Deno will no longer show up in our integrations nav:
I think that was clear from our discussion, but might be worth us checking where and how we want to highlight its existence in the future, so that people who want it can still find it.
|
Following @delucis comment above re: now Deno doesn't show up on our list, I updated the SSR page with links to both the integrations directory on astro.build and to our official integrations guide page in docs. |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
What kind of changes does this PR include?
Description
@astrojs/netlifyand@astrojs/denofrom docs generation as those integrations are no longer controlled by core. They will be documented in their own repository, like with any other 3rd party package.Related Issue / Implementation PR