Skip to content

i18n(ja) Update guides/client-side-scripts.mdx#4996

Merged
yanthomasdev merged 6 commits into
withastro:mainfrom
piro-hiroki:i18n-ja-client-side-scripts
Oct 9, 2023
Merged

i18n(ja) Update guides/client-side-scripts.mdx#4996
yanthomasdev merged 6 commits into
withastro:mainfrom
piro-hiroki:i18n-ja-client-side-scripts

Conversation

@piro-hiroki
Copy link
Copy Markdown
Contributor

@piro-hiroki piro-hiroki commented Oct 8, 2023 •
edited
Loading

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 8, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 5bfb9fb
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/652463f9fab18600080bd944
😎 Deploy Preview https://deploy-preview-4996--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 8, 2023
astrobot-houston
astrobot-houston reviewed Oct 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

okonomi
okonomi reviewed Oct 9, 2023
View reviewed changes
Comment thread src/content/docs/ja/guides/client-side-scripts.mdx Outdated
okonomi
okonomi approved these changes Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@okonomi okonomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます！
LGTM!

yanthomasdev
yanthomasdev approved these changes Oct 9, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work @piro-hiroki, and welcome to Team Docs! 🥳

@yanthomasdev yanthomasdev merged commit ffd6714 into withastro:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@astrobot-houston astrobot-houston astrobot-houston left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

+1 more reviewer

@okonomi okonomi okonomi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@piro-hiroki @okonomi @yanthomasdev @astrobot-houston