Skip to content

i18n(ja): Add new space.mdx translation#5094

Merged
sarah11918 merged 11 commits into
withastro:mainfrom
piro-hiroki:i18n-ja-space
Dec 19, 2023
Merged

i18n(ja): Add new space.mdx translation#5094
sarah11918 merged 11 commits into
withastro:mainfrom
piro-hiroki:i18n-ja-space

Conversation

@piro-hiroki
Copy link
Copy Markdown
Contributor

@piro-hiroki piro-hiroki commented Oct 14, 2023

Description (required)

Translate space.mdx into Japanese！

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 14, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 74d3a55
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/652d2f1b3deccb0008547fbf
😎 Deploy Preview https://deploy-preview-5094--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 14, 2023
@piro-hiroki piro-hiroki changed the title i18n(ja) Translate space.mdx i18n(ja): Add new space.mdx translation Oct 14, 2023
@piro-hiroki piro-hiroki marked this pull request as draft November 8, 2023 12:12
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Nov 24, 2023

Hi @piro-hiroki ! Just checking if this PR should still be marked as a draft?

If it's ready for editing, then please change the status so that it is ready for review! We are hoping to merge as many PRs by next week as we can before the docs site code migrates to Starlight. So if this is ready, we would like to be able to review it. Thanks!

@sarah11918 sarah11918 marked this pull request as ready for review December 3, 2023 01:08
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 3, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 19, 2023 5:59pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2023 5:59pm

piro-hiroki
piro-hiroki commented Dec 3, 2023
View reviewed changes
Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
@piro-hiroki
Copy link
Copy Markdown
Contributor Author

piro-hiroki commented Dec 3, 2023

Hi @sarah11918 !

I've had it as a draft for a long time, but I'm planning to take some time to get it ready for review!
Please wait a little longer!

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Dec 3, 2023

Hi @piro-hiroki ! Sorry, I didn't mean to rush you, just trying to make these visible! 😄

morinokami
morinokami reviewed Dec 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

何点かコメントしましたので、ご確認をお願いします🙏

Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
morinokami
morinokami reviewed Dec 4, 2023
View reviewed changes
Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
@morinokami morinokami mentioned this pull request Dec 4, 2023
Merged
sarah11918 and others added 2 commits December 16, 2023 20:47
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Dec 17, 2023

Hi @piro-hiroki ! These PRs have been here for a while, so I have added @morinokami 's suggestions on the ones with suggestions and updated the branch to match the current version of docs.

Please let me know if you feel these are good enough to merge!

morinokami
morinokami reviewed Dec 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 Added a suggestion to reflect the changes added in #4805. Once it's fixed, it should be good to merge!

Comment thread src/content/docs/ja/guides/deploy/space.mdx Outdated
@sarah11918 @morinokami
Update src/content/docs/ja/guides/deploy/space.mdx
788f591 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Dec 19, 2023
@sarah11918 sarah11918 merged commit 824c910 into withastro:main Dec 19, 2023
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@piro-hiroki @morinokami
@sarah11918 @ematipico
i18n(ja): Add new space.mdx translation (#5094)
90ad578 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morinokami morinokami morinokami left review comments

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piro-hiroki @sarah11918 @morinokami