Skip to content

i18n(ja): Add new cloudflare.mdx translation#5109

Merged
sarah11918 merged 6 commits into
withastro:mainfrom
piro-hiroki:i18n-ja-cloudflare
Dec 23, 2023
Merged

i18n(ja): Add new cloudflare.mdx translation#5109
sarah11918 merged 6 commits into
withastro:mainfrom
piro-hiroki:i18n-ja-cloudflare

Conversation

@piro-hiroki
Copy link
Copy Markdown
Contributor

@piro-hiroki piro-hiroki commented Oct 15, 2023

Description (required)

Translate cloudflare.mdx into Japanese！

file: guides/deploy/cloudflare.mdx

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 15, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit acafc1f
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/652c1440aa30770007824ae1
😎 Deploy Preview https://deploy-preview-5109--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 15, 2023
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Nov 24, 2023

Hi @piro-hiroki ! Just checking if this PR should still be marked as a draft?

If it's ready for editing, then please change the status so that it is ready for review! We are hoping to merge as many PRs by next week as we can before the docs site code migrates to Starlight. So if this is ready, we would like to be able to review it. Thanks!

@sarah11918 sarah11918 marked this pull request as ready for review December 3, 2023 01:08
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 23, 2023 5:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2023 5:45pm

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Dec 17, 2023

Hi @piro-hiroki ! Is this one ready for a review now?

morinokami
morinokami requested changes Dec 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@morinokami morinokami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 Added some suggestions! I think we can merge this PR once those suggestions are merged.

@piro-hiroki Please let me know if you have anything to add!

Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
Comment thread src/content/docs/ja/guides/deploy/cloudflare.mdx Outdated
@sarah11918 @morinokami
Apply suggestions from Shinya code review
4058eb9 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
sarah11918
sarah11918 approved these changes Dec 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sarah11918 sarah11918 merged commit b8a09e1 into withastro:main Dec 23, 2023
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@piro-hiroki @morinokami
@sarah11918 @ematipico
i18n(ja): Add new cloudflare.mdx translation (#5109)
b066155 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morinokami morinokami morinokami requested changes

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piro-hiroki @sarah11918 @morinokami