fix(integration pages ci): ignore private packages#5117
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Contributor
Author
|
Tested by pointing CI to this PR. |
TheOtterlord
approved these changes
Oct 16, 2023
Member
TheOtterlord
left a comment
TheOtterlord
left a comment
There was a problem hiding this comment.
Thanks! Looks good to me! Not sure if anyone else is also doing a pass before we merge
alexanderniebuhr
approved these changes
Oct 16, 2023
Member
alexanderniebuhr
left a comment
alexanderniebuhr
left a comment
There was a problem hiding this comment.
@matthewp already said in Discord this fix looks good to him.
It also lgtm!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
The adapters repo is introducing a private package for testing that does not need to be processed by docs.
Currently, smoke tests are failing because
generate-integration-pages.tsattempts to create a markdown file for the internal test-utils package.Related issues & labels (optional)
None