Skip to content

Add insert on import#5155

Merged
sarah11918 merged 3 commits into
withastro:mainfrom
jacc:patch-1
Oct 19, 2023
Merged

Add insert on import#5155
sarah11918 merged 3 commits into
withastro:mainfrom
jacc:patch-1

Conversation

@jacc
Copy link
Copy Markdown
Contributor

@jacc jacc commented Oct 19, 2023

Description (required)

In the documentation for SSR, the first example about adding nodejs to your Astro config is not highlighted as an import, whereas the second example (converting a static site) highlights nodejs as an import. This PR fixes that.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 19, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 621bfc9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/653173a5878e9b00080a0d37
😎 Deploy Preview https://deploy-preview-5155--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Oct 19, 2023
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, and you're absolutely right.

Happy to welcome you and your eagle eyes to Team Docs! 🫡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants