Skip to content

Fix broken import statement in server-side-rendering.mdx#5442

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
mingjunlu:fix/ssr-manual-install-typo
Nov 22, 2023
Merged

Fix broken import statement in server-side-rendering.mdx#5442
sarah11918 merged 2 commits into
withastro:mainfrom
mingjunlu:fix/ssr-manual-install-typo

Conversation

@mingjunlu
Copy link
Copy Markdown
Contributor

@mingjunlu mingjunlu commented Nov 17, 2023

Description

This PR fixes the broken import statement in the Manual Install section of On⁠-⁠demand Rendering Adapters.

It causes an error when starting the development server.

[astro] Unable to load your Astro config

 error   Failed to resolve entry for package "@astrojs/vercel". The package may have incorrect main/module/exports specified in its package.json: Missing "." specifier in "@astrojs/vercel" package

Related issues & labels

  • Suggested label: code snippet update

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 22, 2023 11:30pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 17, 2023
@mingjunlu mingjunlu changed the title [i18nIgnore] Fix a typo in server-side-rendering.mdx [i18nIgnore] Fix broken import statement in server-side-rendering.mdx Nov 19, 2023
@mingjunlu mingjunlu changed the title [i18nIgnore] Fix broken import statement in server-side-rendering.mdx Fix broken import statement in server-side-rendering.mdx Nov 21, 2023
@github-actions github-actions Bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 21, 2023
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this, @mingjunlu ! 🙌

@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Nov 22, 2023
@sarah11918 sarah11918 merged commit 3111f0c into withastro:main Nov 22, 2023
@mingjunlu mingjunlu deleted the fix/ssr-manual-install-typo branch November 23, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants