[islands] refreshed page content for 4.0#5461
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Member
yanthomasdev
left a comment
yanthomasdev
left a comment
There was a problem hiding this comment.
Just a few nits, overall LGTM!
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Member
|
LOVE this post! |
sarah11918
commented
Nov 20, 2023
sarah11918
commented
Nov 20, 2023
sarah11918
commented
Nov 20, 2023
FredKSchott
approved these changes
Nov 20, 2023
Member
FredKSchott
left a comment
FredKSchott
left a comment
There was a problem hiding this comment.
LGTM! I gave this a read last night and thought it was overall great! I can give a deeper read later this week to look for specific edits and suggestions if it would help, but also don't let me block / consider this my official +1!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This refreshes the page content of
/concepts/islands.mdxto go along with concept changes for Why Astro and Getting Started.Mostly Fred's content changes, with Sarah's light editing.