Fix incorrect return values in server-side-rendering.mdx#5470
Merged
sarah11918 merged 2 commits intoNov 22, 2023
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dreyfus92
requested changes
Nov 21, 2023
Member
There was a problem hiding this comment.
Thank you for handling this @mingjunlu. One note is that these changes only should be applied to the en version of the docs since we already have a tracker that can let know other translators about changes applied to it. I'd encourage you to only leave the changes for the en version. Aside from the suggestion LGTM 😁
Contributor
Author
|
@dreyfus92 Got it! Thanks for the explanation. Changes have been applied to the |
sarah11918
approved these changes
Nov 22, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for jumping on this issue, @mingjunlu ! 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the incorrect return values of endpoint-related snippets in server-side-rendering.mdx.
Related issues & labels