Skip to content

Fix incorrect return values in server-side-rendering.mdx#5470

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
mingjunlu:fix/ssr-endpoint-incorrect-return-value
Nov 22, 2023
Merged

Fix incorrect return values in server-side-rendering.mdx#5470
sarah11918 merged 2 commits into
withastro:mainfrom
mingjunlu:fix/ssr-endpoint-incorrect-return-value

Conversation

@mingjunlu
Copy link
Copy Markdown
Contributor

Description

This PR fixes the incorrect return values of endpoint-related snippets in server-side-rendering.mdx.

Related issues & labels

@vercel
Copy link
Copy Markdown

vercel Bot commented Nov 21, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Nov 22, 2023 11:41pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 21, 2023
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for handling this @mingjunlu. One note is that these changes only should be applied to the en version of the docs since we already have a tracker that can let know other translators about changes applied to it. I'd encourage you to only leave the changes for the en version. Aside from the suggestion LGTM 😁

@github-actions github-actions Bot removed the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Nov 21, 2023
@mingjunlu
Copy link
Copy Markdown
Contributor Author

@dreyfus92 Got it! Thanks for the explanation. Changes have been applied to the en version only (using git rebase)

Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for jumping on this issue, @mingjunlu ! 🙌

@sarah11918 sarah11918 merged commit c148498 into withastro:main Nov 22, 2023
@sarah11918 sarah11918 added the code snippet update Updates a code sample: typo, outdated code etc. label Nov 22, 2023
@mingjunlu mingjunlu deleted the fix/ssr-endpoint-incorrect-return-value branch November 23, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code snippet update Updates a code sample: typo, outdated code etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

check on example using deprecated feature returning plain object instead of Response

3 participants