Skip to content

i18n(ja): Update getting-started.mdx#5609

Merged
yanthomasdev merged 6 commits into
withastro:mainfrom
morinokami:i18n-ja-getting-started-4
Dec 6, 2023
Merged

i18n(ja): Update getting-started.mdx#5609
yanthomasdev merged 6 commits into
withastro:mainfrom
morinokami:i18n-ja-getting-started-4

Conversation

@morinokami
Copy link
Copy Markdown
Member

@morinokami morinokami commented Dec 5, 2023

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 6, 2023 6:36pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Dec 5, 2023
Copy link
Copy Markdown
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいですが、1点だけコメントさせて頂きました
お手すきの際にご確認ください

Comment thread src/content/docs/ja/getting-started.mdx Outdated
morinokami and others added 2 commits December 7, 2023 01:02
Co-authored-by: ryu <114303361+ryuapp@users.noreply.github.com>
@morinokami
Copy link
Copy Markdown
Member Author

@ryuapp ありがとうございます!確かに「アーキテクチャ」と「アーキテクチャー」で表記揺れしてしまっていますね。自分はどちらが適切かわからないのですが、コードベースを検索した感じでは伸ばさないほうが多そうだったので、「アーキテクチャ」にしようかと思います。ついでに用語集も更新しておきました!

@morinokami morinokami requested a review from ryuapp December 6, 2023 16:12
Copy link
Copy Markdown
Contributor

@ryuapp ryuapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morinokami
修正、用語集の更新ありがとうございました
LGTM🎈🎈🎈

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work peeps 🚀

@yanthomasdev yanthomasdev merged commit a14a9eb into withastro:main Dec 6, 2023
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* i18n(ja): Update getting-started.mdx

* 44bc0a3

* Update src/content/docs/ja/getting-started.mdx

Co-authored-by: ryu <114303361+ryuapp@users.noreply.github.com>

* Update i18n/ja/README.md

---------

Co-authored-by: ryu <114303361+ryuapp@users.noreply.github.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants