Skip to content

Bring back heading anchor links#5610

Merged
delucis merged 3 commits into
mainfrom
chris/dx-855
Dec 5, 2023
Merged

Bring back heading anchor links#5610
delucis merged 3 commits into
mainfrom
chris/dx-855

Conversation

@delucis
Copy link
Copy Markdown
Member

@delucis delucis commented Dec 5, 2023

Description (required)

This PR brings back heading anchor links that were not yet implemented in #4266.

Here are some comparison screenshots of the old site design and this new design.

before after
touch devices and narrow viewports image image
large viewports on heading hover image image
large viewports on link hover image image

@delucis delucis added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Dec 5, 2023
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 5, 2023 9:14pm

Copy link
Copy Markdown
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@sarah11918 sarah11918 added 4.0 Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! and removed 4.0 labels Dec 5, 2023
@at-the-vr
Copy link
Copy Markdown
Member

Tested on upgrade to v3 anchor links are working 💯

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you wish!

@delucis delucis merged commit 2429811 into main Dec 5, 2023
@delucis delucis deleted the chris/dx-855 branch December 5, 2023 21:15
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! site improvement Some thing that improves the website functionality - ask @delucis for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants