Skip to content

fix(vite): remove unnecessary code#5667

Merged
sarah11918 merged 2 commits into
withastro:mainfrom
jsparkdev:fix-vite
Dec 8, 2023
Merged

fix(vite): remove unnecessary code#5667
sarah11918 merged 2 commits into
withastro:mainfrom
jsparkdev:fix-vite

Conversation

@jsparkdev
Copy link
Copy Markdown
Member

Description (required)

The bug where import.meta.env is not rendered properly appears to have been resolved in the current version of Vite.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 8, 2023 8:38pm

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The end of an era! We've gone through so many hacks and workarounds for this. 😄

@sarah11918 sarah11918 added typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Dec 8, 2023
@sarah11918 sarah11918 merged commit dd07cd5 into withastro:main Dec 8, 2023
@jsparkdev jsparkdev deleted the fix-vite branch December 9, 2023 00:49
ematipico pushed a commit that referenced this pull request Jan 26, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants