Skip to content

Update: Vite no longer statically replaces import.meta.env#5863

Merged
lilnasy merged 4 commits into
mainfrom
env-handling-update
Dec 21, 2023
Merged

Update: Vite no longer statically replaces import.meta.env#5863
lilnasy merged 4 commits into
mainfrom
env-handling-update

Conversation

@lilnasy
Copy link
Copy Markdown
Contributor

@lilnasy lilnasy commented Dec 20, 2023

Description (required)

Vite 5 switched its behvaior, an Astro plugin performs this now.

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 21, 2023 4:57pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 21, 2023 4:57pm

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating @lilnasy ! LGTM!

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! labels Dec 21, 2023
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you guys think about rewording a lil' bit for clarity?

Comment thread src/content/docs/en/guides/environment-variables.mdx Outdated
@sarah11918 sarah11918 removed the Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! label Dec 21, 2023
sarah11918 and others added 2 commits December 21, 2023 12:42
Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@sarah11918
Copy link
Copy Markdown
Member

@lilnasy If you're happy with this, we're happy! Merge when you're ready!

@sarah11918 sarah11918 added the Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! label Dec 21, 2023
@lilnasy lilnasy merged commit 472379a into main Dec 21, 2023
@lilnasy lilnasy deleted the env-handling-update branch December 21, 2023 21:15
yanthomasdev added a commit that referenced this pull request Jan 4, 2024
* i18n(fr) Update `environment-variables.mdx`

Update french translation for environment-variables.mdx file with PR #5863

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
* i18n(fr) Update `environment-variables.mdx`

Update french translation for environment-variables.mdx file with PR #5863

* Update src/content/docs/fr/guides/environment-variables.mdx

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>

---------

Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs is happy if OP is happy! Please review your PR and make sure you accept our proposed changes! improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants