Skip to content

feat: clarification on dynamic file creation#5886

Closed
pReya wants to merge 1 commit into
withastro:mainfrom
pReya:patch-2
Closed

feat: clarification on dynamic file creation#5886
pReya wants to merge 1 commit into
withastro:mainfrom
pReya:patch-2

Conversation

@pReya
Copy link
Copy Markdown
Contributor

@pReya pReya commented Dec 22, 2023

Description (required)

Adding another paragraph on top of #5880 to clarify that dynamically created files during build process will not be part of the output folder, but'll have to be copied manually.

Related issues & labels (optional)

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 22, 2023 10:58pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 22, 2023 10:58pm

@sarah11918
Copy link
Copy Markdown
Member

Hi! I appreciate the submission, but as I wrote in the issue, I really think this is too much for this page. Certainly, I'm really hesitant to have a flaming caution on our most basic project structure page. As I wrote in the issue, I would consider a recipe with a workaround, and we could use our "related recipes" link component here (e.g. "Related Recipe: Adding files to the public folder during the build process". But I really do think this goes a little too far here. So, I'm closing this, but would be open to having a recipe submitted!

@sarah11918 sarah11918 closed this Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to dynamically create/add/download files to public folder during the build process

2 participants