Skip to content

docs: update Netlify import#5977

Merged
TheOtterlord merged 2 commits into
withastro:mainfrom
orimdominic:patch-1
Dec 28, 2023
Merged

docs: update Netlify import#5977
TheOtterlord merged 2 commits into
withastro:mainfrom
orimdominic:patch-1

Conversation

@orimdominic
Copy link
Copy Markdown
Contributor

@orimdominic orimdominic commented Dec 28, 2023

Description (required)

A warning message about @astrojs/netlify/functions folder is reported on the terminal when I run the build script.

See screenshot attached in the PR
Screenshot from 2023-12-28 13-57-30

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@orimdominic
docs: update Netlify import
3b45606 
A warning message about @astrojs/netlify/functions folder is reported on the terminal when I run the build script.

See screenshot attached in the PR
@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Dec 28, 2023 3:02pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 3:02pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Dec 28, 2023

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

TheOtterlord
TheOtterlord approved these changes Dec 28, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @orimdominic! This looks good to me. Looks like this is also still recommended in the netlify adapter's README. So we'll need to update it there as well

@TheOtterlord TheOtterlord mentioned this pull request Dec 28, 2023
Closed
@TheOtterlord TheOtterlord merged commit 6755219 into withastro:main Dec 28, 2023
@100gle 100gle mentioned this pull request Dec 29, 2023
Merged
@McFlyPartages McFlyPartages mentioned this pull request Jan 3, 2024
Merged
yanthomasdev added a commit that referenced this pull request Jan 4, 2024
@McFlyPartages @yanthomasdev
i18n(fr) Update netlify.mdx (#6089)
040f039 
Update french translation for netlify.mdx file with PR #5528 and #5977

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@orimdominic @TheOtterlord @ematipico
docs: update Netlify import (#5977)
8de845e 
A warning message about @astrojs/netlify/functions folder is reported on the terminal when I run the build script.

See screenshot attached in the PR

Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@McFlyPartages @yanthomasdev @ematipico
i18n(fr) Update netlify.mdx (#6089)
1505762 
Update french translation for netlify.mdx file with PR #5528 and #5977

Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@morinokami morinokami mentioned this pull request Mar 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@orimdominic @astrobot-houston @TheOtterlord