Skip to content

i18n(zh-cn): Update solid-js.mdx#6112

Merged
sarah11918 merged 5 commits into
withastro:mainfrom
huyikai:20240104-translate-solid-js.mdx
Jan 5, 2024
Merged

i18n(zh-cn): Update solid-js.mdx#6112
sarah11918 merged 5 commits into
withastro:mainfrom
huyikai:20240104-translate-solid-js.mdx

Conversation

@huyikai
Copy link
Copy Markdown
Contributor

@huyikai huyikai commented Jan 4, 2024 •
edited
Loading

Description (required)

Update solid-js.mdx

Related issues & labels (optional)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 5, 2024 2:08am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 5, 2024 2:08am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jan 4, 2024
liruifengv
liruifengv approved these changes Jan 4, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 5, 2024

@huyikai @liruifengv - This file had additions today (new section at the bottom). Would you like to add those changes here, too?

@huyikai
Copy link
Copy Markdown
Contributor Author

huyikai commented Jan 5, 2024

@huyikai @liruifengv - This file had additions today (new section at the bottom). Would you like to add those changes here, too?

Yes, We'll let you know when it's updated.

@huyikai
Copy link
Copy Markdown
Contributor Author

huyikai commented Jan 5, 2024

@liruifengv Updated, please review

liruifengv
liruifengv reviewed Jan 5, 2024
View reviewed changes
Comment thread src/content/docs/zh-cn/guides/integrations-guide/solid-js.mdx Outdated
@huyikai @liruifengv
Update src/content/docs/zh-cn/guides/integrations-guide/solid-js.mdx
4bda693 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
liruifengv
liruifengv approved these changes Jan 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@huyikai
Copy link
Copy Markdown
Contributor Author

huyikai commented Jan 5, 2024

@sarah11918 ready

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 5, 2024
@sarah11918 sarah11918 merged commit 09c654f into withastro:main Jan 5, 2024
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@huyikai @liruifengv
@sarah11918 @ematipico
i18n(zh-cn): Update solid-js.mdx (#6112)
4c331a4 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liruifengv liruifengv liruifengv approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@huyikai @sarah11918 @liruifengv