Skip to content

Adapter enhancements in Astro 4.2#6315

Merged
lilnasy merged 11 commits into
mainfrom
adapter-enhancements
Jan 17, 2024
Merged

Adapter enhancements in Astro 4.2#6315
lilnasy merged 11 commits into
mainfrom
adapter-enhancements

Conversation

@lilnasy
Copy link
Copy Markdown
Contributor

@lilnasy lilnasy commented Jan 12, 2024

Description (required)

Documents new options in the adapter API being introduced in Astro 4.2

Related issues & labels (optional)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 17, 2024 5:40pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 5:40pm

@lilnasy lilnasy mentioned this pull request Jan 12, 2024
Merged
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Jan 12, 2024
@sarah11918 sarah11918 added this to the 4.2.0 milestone Jan 12, 2024
alexnguyennz
alexnguyennz reviewed Jan 13, 2024
View reviewed changes
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
@lilnasy
Apply suggestions from code review
eb2212b 
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
VoxelMC
VoxelMC reviewed Jan 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@VoxelMC VoxelMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello!!

I know it's still a draft, but should we entertain the idea of having some Expressive Code here? Since we are not inlining the options in the function, it might be helpful if the eyes have somewhere to snap to!

Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
sarah11918
sarah11918 reviewed Jan 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor polishing here, @lilnasy ! Not much work at all!

Just to double-triple check: did you also go through closely all the code examples on this page and update any that might be affected? (I don't see any updates/corrects in code, so does that mean we were good?)

Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
@lilnasy
Copy link
Copy Markdown
Contributor Author

lilnasy commented Jan 15, 2024

did you also go through closely all the code examples on this page
Not yet. I meant to take a look at the deployed preview for a final look. I'll do that now.

@lilnasy @sarah11918 @VoxelMC
Apply suggestions from code review
229c0e7 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: voxel!() <voxelmc@hotmail.com>
@lilnasy lilnasy marked this pull request as ready for review January 15, 2024 17:55
@lilnasy
Copy link
Copy Markdown
Contributor Author

lilnasy commented Jan 15, 2024

There seems to be nothing else to update on the page. I do want to order RenderOptions alphabetically.

sarah11918
sarah11918 reviewed Jan 17, 2024
View reviewed changes
Comment thread src/content/docs/en/reference/adapter-reference.mdx
sarah11918
sarah11918 reviewed Jan 17, 2024
View reviewed changes
Comment thread src/content/docs/en/reference/adapter-reference.mdx
sarah11918
sarah11918 reviewed Jan 17, 2024
View reviewed changes
Comment thread src/content/docs/en/reference/adapter-reference.mdx
sarah11918
sarah11918 approved these changes Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lilnasy Would love one final review from you on this, as I made some tiny adjustments (e.g. linked within-page to headings, and then linked those to other pages)

But on my end, this feels good to go!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 17, 2024
@lilnasy
Copy link
Copy Markdown
Contributor Author

lilnasy commented Jan 17, 2024

I was watching 👀. Love the edit around RenderOptions. Looks great to me!

VoxelMC
VoxelMC reviewed Jan 17, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@VoxelMC VoxelMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work so far!

Just some cleanup here, let me know if it's incorrect at all!

Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
Comment thread src/content/docs/en/reference/adapter-reference.mdx Outdated
@lilnasy lilnasy merged commit d06ad1a into main Jan 17, 2024
@lilnasy lilnasy deleted the adapter-enhancements branch January 17, 2024 21:27
@TheOtterlord TheOtterlord restored the adapter-enhancements branch January 17, 2024 21:39
@TheOtterlord TheOtterlord mentioned this pull request Jan 17, 2024
Closed
@jsparkdev jsparkdev mentioned this pull request Jan 18, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jan 18, 2024
Merged
ematipico pushed a commit that referenced this pull request Jan 26, 2024
@lilnasy @sarah11918
@VoxelMC @ematipico
Adapter enhancements in Astro 4.2 (#6315)
13e65be 
* Adapter enhancements in Astro 4.2

* Apply suggestions from code review

Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>

* Apply suggestions from code review

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: voxel!() <voxelmc@hotmail.com>

* routeData, locals -> locals, routeData

* thanks for the complex punctuation Arsh

* line spacing

* explain/link what locals is before the example

* line spacing

* updates link strategy

* fix link

* fix more stupid links

---------

Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: voxel!() <voxelmc@hotmail.com>
@ArmandPhilippot ArmandPhilippot mentioned this pull request Dec 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

+2 more reviewers

@VoxelMC VoxelMC VoxelMC left review comments

@alexnguyennz alexnguyennz alexnguyennz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

4.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@lilnasy @sarah11918 @VoxelMC @alexnguyennz