Skip to content

update decap docs#6800

Merged
sarah11918 merged 18 commits into
withastro:mainfrom
OliverSpeir:update-decap
Mar 10, 2024
Merged

update decap docs#6800
sarah11918 merged 18 commits into
withastro:mainfrom
OliverSpeir:update-decap

Conversation

@OliverSpeir
Copy link
Copy Markdown
Contributor

@OliverSpeir OliverSpeir commented Feb 6, 2024

Description (required)

  • Removes mention old integration ( no longer actively maintained )
  • Adds more information about the CMS and how to use it with astro
  • Adds community resource templates

@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 10, 2024 2:37pm

alexnguyennz
alexnguyennz reviewed Feb 7, 2024
View reviewed changes
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
OliverSpeir and others added 4 commits February 8, 2024 05:58
@OliverSpeir
Update src/content/docs/en/guides/cms/decap-cms.mdx
5931e1f 
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
@OliverSpeir
Update src/content/docs/en/guides/cms/decap-cms.mdx
0b436c6 
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
@OliverSpeir
Update src/content/docs/en/guides/cms/decap-cms.mdx
1c01de0 
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
@OliverSpeir
Update src/content/docs/en/guides/cms/decap-cms.mdx
000e758 
Co-authored-by: Alex Nguyen <dev@alexnguyen.co.nz>
@OliverSpeir
Copy link
Copy Markdown
Contributor Author

OliverSpeir commented Feb 8, 2024

Thank you Alex!

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Feb 8, 2024
sarah11918
sarah11918 reviewed Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @OliverSpeir ! Thanks for updating the outdated community resources and providing more of an actual "guide" here!

The guide part needs a bit of massaging, so I've left some comments to show what I think a helpful page here would look like. Note: these are NOT correct, as-is, edits. They are only to show what I'd want this page to look like with snippets taken from their docs (that are not necessarily Astro-fied).

Are you interested in continuing to work on this to get it over the line?

Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
@OliverSpeir
Copy link
Copy Markdown
Contributor Author

OliverSpeir commented Feb 16, 2024

Yeah I’ll keep working on this, thanks for such a detailed review! Sorry for submitting it in such a rough form haha

OliverSpeir and others added 4 commits February 18, 2024 10:40
@OliverSpeir @sarah11918
Update src/content/docs/en/guides/cms/decap-cms.mdx
39d5902 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@OliverSpeir @sarah11918
Update src/content/docs/en/guides/cms/decap-cms.mdx
8d5b2b3 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@OliverSpeir @sarah11918
Update src/content/docs/en/guides/cms/decap-cms.mdx
494b1c8 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@OliverSpeir @sarah11918
Update src/content/docs/en/guides/cms/decap-cms.mdx
fecedd6 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Feb 19, 2024

Just lemme know when you'd like me to look over this again! I'll wait to review until you ask for it, @OliverSpeir !

@OliverSpeir
Copy link
Copy Markdown
Contributor Author

OliverSpeir commented Feb 19, 2024

Thank you @sarah11918, I think it's ready for another review!

sarah11918
sarah11918 reviewed Feb 20, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small things here, but this is looking great, I think! Tag, you're it!

Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
@OliverSpeir @sarah11918
Apply suggestions from code review
5da57ef 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@OliverSpeir
Copy link
Copy Markdown
Contributor Author

OliverSpeir commented Mar 6, 2024

@sarah11918 sorry for long delay, but I think it should be good now, thanks for all the detailed reviews. Let me know what you think whenever you get a chance again!

sarah11918
sarah11918 reviewed Mar 10, 2024
View reviewed changes
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
sarah11918
sarah11918 approved these changes Mar 10, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I think this looks great! Thanks for your patience as I've been consumed with "other docs" recently. 😅

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 10, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Mar 10, 2024

gah, filetree not happy

@sarah11918 sarah11918 removed the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 10, 2024
sarah11918
sarah11918 reviewed Mar 10, 2024
View reviewed changes
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx
sarah11918
sarah11918 reviewed Mar 10, 2024
View reviewed changes
Comment thread src/content/docs/en/guides/cms/decap-cms.mdx Outdated
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 10, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Mar 10, 2024

Alright, I think we finally got this, thank you so much @OliverSpeir ! 🙌

@sarah11918 sarah11918 merged commit dc4848c into withastro:main Mar 10, 2024
@mearashadowfax mearashadowfax mentioned this pull request Mar 10, 2024
Merged
@huyikai huyikai mentioned this pull request Mar 11, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Mar 13, 2024
Merged
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request May 19, 2025
@ArmandPhilippot
i18n(fr): update guides/cms/decap-cms.mdx
5b3269f 
See withastro#6800 and withastro#10117
@ArmandPhilippot ArmandPhilippot mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

+1 more reviewer

@alexnguyennz alexnguyennz alexnguyennz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OliverSpeir @sarah11918 @alexnguyennz