Skip to content

Updated PreprCMS guide#6983

Merged
sarah11918 merged 7 commits into
withastro:mainfrom
mlingham79:patch-1
Feb 27, 2024
Merged

Updated PreprCMS guide#6983
sarah11918 merged 7 commits into
withastro:mainfrom
mlingham79:patch-1

Conversation

@mlingham79
Copy link
Copy Markdown
Contributor

Description (required)

Updated the Prepr CMS page with detailed instructions to connect an Astro project to Prepr CMS.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

First-time contributor to Astro Docs

Added instructions to integrate Astro with Prepr CMS. With additional steps to make a simple blog.
Added corrections to the FileTree and updated typos
Corrected typos to render code snippets, images and file trees.
@vercel
Copy link
Copy Markdown

vercel Bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Feb 27, 2024 11:09pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918
Copy link
Copy Markdown
Member

Hi @mlingham79! Wow, what a first contribution to Astro Docs! This is a big one, and we are so happy to receive it. 😄

I just wanted to let you know I'll be reviewing this in the next day or so, and I've already skimmed it and it's looking great! This is one of the more polished contributions we've received from a community member by far, and it will be my pleasure to review it.

You've done an amazing job here, so I'll just be doing some structural edits to conform to our existing style, just so you know what's going on. For example, we don't use screenshots in Astro docs, so I might be adjusting some text to articulate content in words vs relying on screenshots. I'll also just be tweaking for our standard voice, verb tenses etc. Nothing major really! But, this might result in a lot of tiny "paper cuts", so please don't be overwhelmed if we end up with several small suggestions. As I said, I really do feel this is in excellent shape, thoughtful and well-written, so I just need to do some polishing so that it fits in.

You'll see a detailed review from me soon! 💜

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Feb 25, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, are you ready?? 😄

I loved the structure you provided here, and the writing was clear and helpful! This was a delightful guide to work with.

You'll find my suggestions below, most of them quite small. GitHub is also not the greatest way to edit some of this, especially formatting. I know for example that code samples inside numbered lists will all need to be indented a couple of times... but let's save that until we've got a polished product, then take care of the really small things like that! 😅

Thank you again for this wonderful contribution, and I know it might take some time to work through my review comments. No rush on my end! Whenever you get around to it is great!

Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Comment thread src/content/docs/en/guides/cms/preprcms.mdx Outdated
Thanks very much for the suggestions. They are great!

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Added a link to the Astro dynamic routing docs
Copy link
Copy Markdown
Contributor Author

@mlingham79 mlingham79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sarah11918 , Thanks very much for your review and great suggestions. I've committed them and made a small edit to include the Astro docs link for dynamic routing. I'm looking forward to the approval of these changes.

@sarah11918
Copy link
Copy Markdown
Member

This looks great, @mlingham79! Just needed to reread and check indentation levels of the code samples, but I think it's in great shape now. We are very happy to officially welcome you to Team Docs! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants