chore(middleware): clarify usage#7045
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sarah11918
reviewed
Feb 26, 2024
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thanks for adding this clarification @ematipico ! See what you think about my suggestion!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
added
the
improve or update documentation
sarah11918
approved these changes
Feb 27, 2024
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Looks good to me @ematipico ! Happy for you to merge when you're happy!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
In core, we have had some feedback where users expected to have the middleware run also in SSG when the website is deployed.
From one point of view, I can understand this. A middleware should run every time, at runtime, because that's what a middleware is meant for. Although, this isn't the case for our static and prerendered pages.
This PR is meant to add a small note to clarify how the middleware works in Astro.