Replace "Google Cloud Registry" with "Artifact Registry"#7118
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shuuji3
commented
Mar 1, 2024
|
|
||
| **Build locally using Docker**: | ||
|
|
||
| Use the `docker build` command to build the image, `docker tag` to give it a tag, then `docker push` to push it to a registry. In the case of Google Cloud, [`Google Cloud Registry`](https://cloud.google.com/container-registry/docs/pushing-and-pulling#add-registry) is the easiest option, but you can also use [Docker Hub](https://hub.docker.com/). |
Contributor
Author
There was a problem hiding this comment.
The original link directly points to #add-registry but it was skipping a few prerequisites before that section. For example, enabling API is a necessary operation for every new Google Cloud Project so I think it should navigate to the beginning of the page.
sarah11918
approved these changes
Mar 1, 2024
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Looks great! Thank you for being on top of this! 💪
sarah11918
added
typo/link/grammar - quick fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
A while ago, Goole Cloud deprecated Container Registry in favor of Artifact Registry so the linked documentation page is also updated. Artifact Registry is basically a superset of Container Registry so the usage and documentation content is the same.
This PR replaces the service name and its links.
🌐 Preview: https://docs-git-fork-shuuji3-update-google-cloud-astrodotbuild.vercel.app/en/guides/deploy/google-cloud/
Related issues & labels (optional)