Skip to content

i18n(zh-tw): update project-structure.mdx translation#7133

Merged
dreyfus92 merged 5 commits into
withastro:mainfrom
mingjunlu:zh-tw/project-structure
Mar 5, 2024
Merged

i18n(zh-tw): update project-structure.mdx translation#7133
dreyfus92 merged 5 commits into
withastro:mainfrom
mingjunlu:zh-tw/project-structure

Conversation

@mingjunlu
Copy link
Copy Markdown
Contributor

@mingjunlu mingjunlu commented Mar 2, 2024

Description

  • Updates Traditional Chinese translation of src/content/docs/zh-tw/basics/project-structure.mdx

Related issues & labels

  • Closes #
  • Suggested label: i18n

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 5, 2024 3:48am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 2, 2024
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a way to comment on the specified line.
There are some little issues.
Does components in the page need to be changed to 元件?

image

There's no translation in English here.

@mingjunlu
Copy link
Copy Markdown
Contributor Author

I don't have a way to comment on the specified line. There are some little issues. Does components in the page need to be changed to 元件?

image

There's no translation in English here.

Thanks! I've translated the untranslated paragraph and improved translation consistency.

Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Notice that this page uses FileTree. I'm trying to replace it with Starlight's FileTree in #7182.
But don't worry, I'll take care of these.

@liruifengv liruifengv added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 4, 2024
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you peeps, LGTM ✅

@dreyfus92 dreyfus92 merged commit 307e3cf into withastro:main Mar 5, 2024
@mingjunlu mingjunlu deleted the zh-tw/project-structure branch March 5, 2024 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants