Skip to content

fix link and packages in authentication.mdx#7147

Merged
yanthomasdev merged 4 commits into
withastro:mainfrom
jsparkdev:fix-auth
Mar 8, 2024
Merged

fix link and packages in authentication.mdx#7147
yanthomasdev merged 4 commits into
withastro:mainfrom
jsparkdev:fix-auth

Conversation

@jsparkdev
Copy link
Copy Markdown
Member

@jsparkdev jsparkdev commented Mar 3, 2024

Description (required)

Related issues & labels (optional)

  • fix incorrect link
  • add missing packages from manual installation

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 8, 2024 7:12pm

Comment thread src/content/docs/en/guides/authentication.mdx Outdated
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks! I've left a couple of comments. One about the URL of the Lucia tutorial, and another about the cookie package

Comment thread src/content/docs/en/guides/authentication.mdx Outdated
Comment thread src/content/docs/en/guides/authentication.mdx Outdated
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
@jsparkdev
Copy link
Copy Markdown
Member Author

jsparkdev commented Mar 4, 2024

I just checked that it runs without having to install the cookie package separately.

However, I have checked that it does not work properly in the latest version of @auth/core and that @auth/core@^0.18.6 is required as shown in auth-astro repository.

So I modified the @auth/core library version.

Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Thanks for checking! I'll see if I can sort out the compatibility issues with the latest version soon.

@sarah11918
Copy link
Copy Markdown
Member

!coauthor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 7, 2024

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Mayank-Malviya <142796129+Mayank-Malviya@users.noreply.github.com>

@yanthomasdev yanthomasdev changed the title fix: typo in authentication.mdx fix link and packages in authentication.mdx Mar 8, 2024
@yanthomasdev
Copy link
Copy Markdown
Member

Thanks @jsparkdev! Since this change involves link and package changes (that should be applied to all languages) I've renamed the title to properly trigger Lunaria.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants