Skip to content

feat(dev-toolbar-reference): Add level property to notifications#7200

Merged
sarah11918 merged 4 commits into
4.5.0from
feat/notification-levels
Mar 8, 2024
Merged

feat(dev-toolbar-reference): Add level property to notifications#7200
sarah11918 merged 4 commits into
4.5.0from
feat/notification-levels

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

Description (required)

withastro/astro#10252 adds new levels possible for notifications. This adds the docs for it.

@Princesseuh Princesseuh added this to the 4.5.0 milestone Mar 5, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 8, 2024 9:28pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Mar 8, 2024 9:28pm

@Princesseuh Princesseuh added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Mar 5, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Princesseuh I think these are correct looking at the PR, so I think it would be helpful to add that here!

Non-blocking though if you prefer not to for maintenance, or think they might change!

Comment thread src/content/docs/en/reference/dev-toolbar-app-reference.mdx Outdated
Comment thread src/content/docs/en/reference/dev-toolbar-app-reference.mdx Outdated
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🥳

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 8, 2024
@sarah11918 sarah11918 merged commit 9630a14 into 4.5.0 Mar 8, 2024
@sarah11918 sarah11918 deleted the feat/notification-levels branch March 8, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants