Adds a note about what internal state of elements can't be preserved by transition:persist#7292
Merged
Conversation
…by transition:persist
…by transition:persist
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sarah11918
approved these changes
Mar 11, 2024
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Just some code formatting, otherwise, good to merge @martrapp ! Thank you for adding this clarification!
sarah11918
added
improve or update documentation
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Member
Author
|
Many thanks for the quick review and improvement! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
A user on discord complained that the current text gives the impression that
transition:persistwould keep all states of an element, while he suffered from restarting animations.He referred to this sentence, which he had taken out of context
It might help to mention the known limitations.