Clarified limitations of using Cloudflare adapter with Node.js#7414
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
alexanderniebuhr
left a comment
alexanderniebuhr
left a comment
There was a problem hiding this comment.
@jmho Thank you for updating the docs.. I'll added some comments already, and I'll also make sure our docs team reviews this too.
|
Just a note that I will come in and do a docs (text/language/formatting) review once all of the technical issues and questions have been resolved! I am not the subject matter expert here, so I am trusting @alexanderniebuhr to clarify all the necessary/important details, and will wait for him to be 100% certain about the content. Then I'll just make sure it sounds pretty and fits with docs structure/standards! 🙌 |
Updated link to use header Co-authored-by: Alexander Niebuhr <alexander@nbhr.io>
jmho
left a comment
jmho
left a comment
There was a problem hiding this comment.
Thanks for the review! I added some additional clarification and accepted some of your changes.
Co-authored-by: Justin Ho <59701887+jmho@users.noreply.github.com>
Co-authored-by: Justin Ho <59701887+jmho@users.noreply.github.com>
alexanderniebuhr
left a comment
alexanderniebuhr
left a comment
There was a problem hiding this comment.
I approve Cloudflare specific technical aspects. Now waiting for docs review!
cc @sarah11918
sarah11918
added
add new content
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for this contribution, @jmho! We appreciate the extra guidance, and are excited to welcome you to Team Docs! 🥳
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for this contribution, @jmho! We appreciate the extra guidance, and are excited to welcome you to Team Docs! 🥳
4 participants
Description (required)
Added additional clarification about the limitations of deploying with the Cloudflare adapter when using packages that import the Node.js runtime without using the
import * from node*syntax. The error message that appears when you run into this is unclear especially in regards to why it is happening, and what the next steps should be for someone.My hope is that with updates to the docs, a developer can understand the following: This is not a bug within Astro, why this error may sometimes occur, and what the next steps are if someone is developing an Astro app that imports relies on packages that might not conform to the
import * from node*syntax.Please let me know if anything needs to be clarified or updated!
(Thanks to @alexanderniebuhr for helping me figure out the original issue!)
Discord: hgswiz
Related issues & labels (optional)
add new content