Update github.mdx#7481
Merged
Merged
Conversation
This example does not work with the leading slash.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
sarah11918
added
the
code snippet update
sarah11918
approved these changes
Mar 20, 2024
Member
sarah11918
left a comment
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for providing this helpful update @ben-milanko , and welcome to Team Docs! 🥳
sarah11918
added
the
Merge Queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This example does not work with the leading slash.
Description (required)
When trying this example out, the leading slash would deploy the site with an empty base, breaking the references.
E.g. when deploying with
base: '/website-astro'the resulting deployed site would have broken links withhttps://ORG.github.io/_astro/...Removing the leading slash
base: 'website-astro'correctly set the base and the references worked ashttps://ORG.github.io/website-astro/_astro/...Related issues & labels (optional)