Skip to content

Update server-side-rendering.mdx and integrations-reference.mdx#7498

Merged
sarah11918 merged 4 commits into
withastro:mainfrom
morinokami:server-side-rendering-1
Mar 25, 2024
Merged

Update server-side-rendering.mdx and integrations-reference.mdx#7498
sarah11918 merged 4 commits into
withastro:mainfrom
morinokami:server-side-rendering-1

Conversation

@morinokami
Copy link
Copy Markdown
Member

Description (required)

  • Corrected the spelling of "NodeJS" and "NodeJs" to the official "Node.js".
  • Removed redundant sections in server-side-rendering.mdx.

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 25, 2024 6:23pm

Comment on lines -132 to -142
You can then choose to override the default on-demand rendering of `server` mode on any page or route by exporting `const prerender = true`:

```astro title="src/pages/my-static-page.astro" ins={2}
---
export const prerender = true;
// ...
---
<html>
<!-- Static, pre-rendered page here... -->
</html>
```
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method for opting into pre-rendering in server mode is described immediately below, and it seems to be redundant. So, I think this part can be safely removed.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call @morinokami ! Thank you!

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. labels Mar 25, 2024
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants