Skip to content

feat: Add a high-level page about the dev toolbar#7503

Merged
sarah11918 merged 6 commits into
mainfrom
feat/dev-toolbar
Mar 25, 2024
Merged

feat: Add a high-level page about the dev toolbar#7503
sarah11918 merged 6 commits into
mainfrom
feat/dev-toolbar

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh commented Mar 20, 2024

Description (required)

Right now it's not super documented that the dev toolbar exists, despite being at the bottom of every single page 😅

This page hopes to serve as an overview of the dev toolbar and its features.

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 25, 2024 3:13pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Mar 25, 2024 3:13pm

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Mar 20, 2024

Thank you! Will take a look at this in the next couple of days, when I can sit down and get comfy with it! 🙌

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Mar 20, 2024
@mingjunlu
Copy link
Copy Markdown
Contributor

mingjunlu commented Mar 20, 2024

This is awesome! The dev toolbar definitely needs more attention 🙌

mingjunlu
mingjunlu reviewed Mar 20, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mingjunlu mingjunlu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well-written! I find it easy to read and understand. Leaving a couple suggestions here:

Comment thread src/content/docs/en/guides/dev-toolbar.mdx Outdated
Comment thread src/content/docs/en/guides/dev-toolbar.mdx Outdated
Comment thread src/content/docs/en/guides/dev-toolbar.mdx Outdated
Comment thread src/content/docs/en/guides/dev-toolbar.mdx Outdated
mingjunlu
mingjunlu reviewed Mar 21, 2024
View reviewed changes
Comment thread src/content/docs/en/guides/dev-toolbar.mdx Outdated
@sarah11918 @mingjunlu
Apply Ming-jun Lu suggestions from code review
65f16e6 
Co-authored-by: Ming-jun Lu <40516784+mingjunlu@users.noreply.github.com>
SatanshuMishra
SatanshuMishra reviewed Mar 22, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@SatanshuMishra SatanshuMishra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great addition! Will definitly give people an insight into how to use the development toolbar. The page was easy to ready and understand. Amazing work making this!

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Mar 25, 2024

@Princesseuh Would love for you to review the changes I made here! Then, when you're happy, I think this is good to merge!

@Princesseuh
Copy link
Copy Markdown
Member Author

Princesseuh commented Mar 25, 2024

@Princesseuh Would love for you to review the changes I made here! Then, when you're happy, I think this is good to merge!

Looks great to me! GitHub should really add a way to review my own PR

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Mar 25, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Mar 25, 2024

!coauthor

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2024 

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Ming-jun Lu <40516784+mingjunlu@users.noreply.github.com>
Co-authored-by: Satanshu Mishra <satanshumishra@outlook.com>

@sarah11918 sarah11918 merged commit 2289354 into main Mar 25, 2024
@sarah11918 sarah11918 deleted the feat/dev-toolbar branch March 25, 2024 16:38
@huyikai huyikai mentioned this pull request Mar 26, 2024
Merged
@jsparkdev jsparkdev mentioned this pull request Mar 27, 2024
Merged
@mingjunlu mingjunlu mentioned this pull request Mar 27, 2024
Merged
This was referenced Mar 31, 2024
Merged
Merged
@mearashadowfax mearashadowfax mentioned this pull request Mar 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mingjunlu mingjunlu mingjunlu left review comments

+1 more reviewer

@SatanshuMishra SatanshuMishra SatanshuMishra left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Princesseuh @sarah11918 @mingjunlu @SatanshuMishra