Skip to content

i18n(ja): Update tutorial/1-setup/index.mdx#7594

Closed
morinokami wants to merge 1 commit into
withastro:mainfrom
morinokami:i18n-ja-tutorial-unit1-index-0
Closed

i18n(ja): Update tutorial/1-setup/index.mdx#7594
morinokami wants to merge 1 commit into
withastro:mainfrom
morinokami:i18n-ja-tutorial-unit1-index-0

Conversation

@morinokami
Copy link
Copy Markdown
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Mar 26, 2024 11:52am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Mar 26, 2024
@liruifengv
Copy link
Copy Markdown
Member

Thank you @morinokami A suggestion. Would you be willing to merge all the tutorial sections into one PR, since we have 24 files and our docs repository is very large and the build time is very long, which will cause us to spend a long time waiting for the CI and then merge it!

@morinokami
Copy link
Copy Markdown
Member Author

@liruifengv Thanks for your suggestion! I understand the concern about the CI build times given the repository's size and agree that merging PRs could take considerable time. However, some files may require not a few changes, and I was worried that combining them all into a single PR might overwhelm reviewers. To strike a balance between reducing CI time and easing the review process, what if we group the updates by chapters rather than consolidating everything into one PR? This approach might offer a middle ground that addresses both concerns. What do you think?

@liruifengv
Copy link
Copy Markdown
Member

Yeah. I think updating by chapter would be a good way to do it

@morinokami
Copy link
Copy Markdown
Member Author

Perfect, thanks! I'll start organizing the PRs by chapter then. (I'll close the existing PRs and recreate them as discussed)

@morinokami morinokami closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants