Skip to content

Document ASTRO_DATABASE_FILE#7723

Merged
matthewp merged 6 commits into
mainfrom
database-file
Apr 8, 2024
Merged

Document ASTRO_DATABASE_FILE#7723
matthewp merged 6 commits into
mainfrom
database-file

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

@matthewp matthewp commented Apr 1, 2024

Description (required)

  • Documents the ASTRO_DATABASE_FILE environment variable.

Related issues & labels (optional)

None

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Apr 8, 2024 1:35pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Apr 8, 2024 1:35pm

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Apr 2, 2024
Copy link
Copy Markdown
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left an initial comment proposing some updates to the structure, and to clarify a few points. I wrote it in one piece, but feel free to pick apart anything you find useful.

Comment thread src/content/docs/en/guides/astro-db.mdx
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking pretty good, and thank you @TheOtterlord Otterlord for a lovely flow here! Two quick additions for explicitness but the opening is really nice!

@matthewp See what you think of my slight reordering of the bottom section, and I wanted to show a second example for the schema migration (which brought up its own naming issue). Can you work with that kind of structure and make it accurate?

PS - I removed the word "omit" (remove?) because I wasn't sure what that was telling me to remove, nor from where. If that's a key word then we'll need to find a way to put it back in with a little more context.

Comment thread src/content/docs/en/guides/astro-db.mdx Outdated
Comment thread src/content/docs/en/guides/astro-db.mdx Outdated
Comment thread src/content/docs/en/guides/astro-db.mdx Outdated
matthewp and others added 2 commits April 3, 2024 21:09
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think all the ticks are worked out here, @matthewp ! I checked the preview and it looks in order.

When you're happy with this, it's good to merge on my end. Happy for you to update branch and merge, or ping me to do it! (I don't think this is waiting for any feature PR first).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants