feat: update minimum Node.js version#7838
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Princesseuh
reviewed
Apr 10, 2024
| #### Prerequisites | ||
|
|
||
| - **Node.js** - `v18.14.1` or higher. | ||
| - **Node.js** - `v18.17.1` or higher. |
Member
There was a problem hiding this comment.
Wonder if this should precise the full requirements, which is 18.17.1 or higher for 18, not 19, and 20.3.0 or higher for 20.
Member
Author
There was a problem hiding this comment.
Good point. If users that are on Node.js v19 now try to install Astro, they will get the engine warning
Member
Author
There was a problem hiding this comment.
I applied the change in 3a32833 (#7838), I will let Sarah decide on the format of the sentence.
sarah11918
reviewed
Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
This PR updates the minimum Node.js version.
For Astro version:
4.6. See astro PR #10689. -->