Skip to content

Update configuring-astro.md#785

Closed
natemoo-re wants to merge 1 commit into
mainfrom
config-env-variables
Closed

Update configuring-astro.md#785
natemoo-re wants to merge 1 commit into
mainfrom
config-env-variables

Conversation

@natemoo-re
Copy link
Copy Markdown
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content
  • Translated content
  • Changes to the docs site code
  • Something else!

Description

  • Adds a new section to configuring-astro.md about referencing environment variables.
  • Also mentions Astro's ability to load config files from the config/ directory, a hidden feature that I personally love and hope more people start using!
  • Paired with Expose loadEnv hook for config files astro#3617

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 16, 2022

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit d788ffe
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/62abb27d74ad140008c3ae39
😎 Deploy Preview https://deploy-preview-785--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Nate 👍

@sarah11918
Copy link
Copy Markdown
Member

LGTM! 🥳

@delucis delucis added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 19, 2022
@sarah11918
Copy link
Copy Markdown
Member

Just a freshness ping, @natemoo-re ! You might not be used to looking at the PRs in this repo as much as the main Astro one. We'll be sure to mention you next time we LGTM, so you know it's good for you to merge!

@natemoo-re
Copy link
Copy Markdown
Member Author

Thanks for the reminder ping @sarah11918! The upstream change for this has yet to be merged in, but I forgot to link it here. Will finish that PR and circle back when it's merged. Switching to draft for now.

@sarah11918 sarah11918 marked this pull request as draft June 27, 2022 15:07
@sarah11918
Copy link
Copy Markdown
Member

@natemoo-re The corresponding Astro PR for this has been closed. Should we close this one too, and reopen if something happens with it upstream?

@delucis
Copy link
Copy Markdown
Member

delucis commented Sep 8, 2022

Seems fair to close this for now — we can reopen if the feature PR gets merged.

@delucis delucis closed this Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants