Skip to content

feat: new toolbar component and button property#8050

Merged
sarah11918 merged 4 commits into
4.8.0from
feat/new-toolbar-components
May 8, 2024
Merged

feat: new toolbar component and button property#8050
sarah11918 merged 4 commits into
4.8.0from
feat/new-toolbar-components

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh commented Apr 29, 2024

Description (required)

Doc for withastro/astro#10906. Adds a new component and a new property for button, simple enough!

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 7, 2024 1:16pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 7, 2024 1:16pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Apr 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/dev-toolbar-app-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

dreyfus92
dreyfus92 approved these changes Apr 29, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@sarah11918 sarah11918 added this to the 4.8 milestone Apr 30, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Apr 30, 2024
sarah11918
sarah11918 reviewed May 1, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You were right, @Princesseuh , pretty simple! 😄 This is good to go but I'd prefer we find a simpler word for "homogeneous". I left a suggestion and alternative below. Pick a word and we're ready for 4.8! 🥳

And, I'm trying very hard to remember myself to always add <p><Since v="4.8.0" /></p> to the new features!

Comment thread src/content/docs/en/reference/dev-toolbar-app-reference.mdx Outdated
Comment thread src/content/docs/en/reference/dev-toolbar-app-reference.mdx
Comment thread src/content/docs/en/reference/dev-toolbar-app-reference.mdx
Princesseuh and others added 2 commits May 2, 2024 11:24
@Princesseuh @sarah11918
Update src/content/docs/en/reference/dev-toolbar-app-reference.mdx
2fb6c67 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@Princesseuh @sarah11918
Apply suggestions from code review
89fc4d0 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. label May 3, 2024
sarah11918
sarah11918 approved these changes May 5, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for 4.8 release! 🥳

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 5, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented May 7, 2024

Updating branch and pointing to new 4.8.0 branch

@sarah11918 sarah11918 changed the base branch from main to 4.8.0 May 7, 2024 13:09
@sarah11918 sarah11918 merged commit 2d6feb7 into 4.8.0 May 8, 2024
@sarah11918 sarah11918 deleted the feat/new-toolbar-components branch May 8, 2024 15:15
@sarah11918 sarah11918 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

4.8

Development

Successfully merging this pull request may close these issues.

4 participants

@Princesseuh @astrobot-houston @sarah11918 @dreyfus92