Skip to content

docs: add preact devtools option#8164

Merged
sarah11918 merged 9 commits into
4.8.0from
feat/preact-devtools
May 8, 2024
Merged

docs: add preact devtools option#8164
sarah11918 merged 9 commits into
4.8.0from
feat/preact-devtools

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

Description (required)

Documents the addition of a devtools option for the preact integration.

Related issues & labels (optional)

  • Closes #
  • Suggested label: merge on release

For Astro version: 4.8. See astro PR #10938.

@florian-lefebvre florian-lefebvre added this to the 4.8 milestone May 2, 2024
@vercel
Copy link
Copy Markdown

vercel Bot commented May 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 8, 2024 3:55pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 8, 2024 3:55pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented May 2, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/preact.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels May 3, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @florian-lefebvre ! Just the same suggestions as in vue: to be a tiny bit more explicit in the text line and add the comonent, but good to go!

For reference:

Note that a new feature should include a <Since> component to display the version it was added in, and you'll need to check that this is also imported at the top of the page as import Since from '~/components/Since.astro';

(These integration pages used to be pulled from plain .md READMES in the astro repo, so they are often missing our nice components!)

Comment thread src/content/docs/en/guides/integrations-guide/preact.mdx Outdated
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. label May 3, 2024
florian-lefebvre and others added 2 commits May 3, 2024 17:38
Comment thread src/content/docs/en/guides/integrations-guide/preact.mdx
@sarah11918
Copy link
Copy Markdown
Member

D'oh! Our <Since /> component is hard-coded to say "astro" because it wasn't available for these other pages in our previous setup. Let me see whether it's easy enough for me to update the component to take an additional prop, or whether we just use Markdown to "fake" this (like we used to)

image

Comment thread src/content/docs/en/guides/integrations-guide/preact.mdx Outdated
Comment thread src/content/docs/en/guides/integrations-guide/preact.mdx Outdated
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for 4.8 release!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 5, 2024
Comment thread src/content/docs/en/guides/integrations-guide/preact.mdx Outdated
@sarah11918
Copy link
Copy Markdown
Member

Updating branch and pointing to 4.8.0 branch!

@sarah11918 sarah11918 changed the base branch from main to 4.8.0 May 8, 2024 15:41
@sarah11918 sarah11918 merged commit c482032 into 4.8.0 May 8, 2024
@sarah11918 sarah11918 deleted the feat/preact-devtools branch May 8, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants