fix: better description and explanation of how to use the dual themes of Shiki#8174
fix: better description and explanation of how to use the dual themes of Shiki#8174ghlps wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hi @gxlpes ! Thank you for picking up on some outstanding issues in the docs repo! 💪 We actually already have an open PR very close to merging to address this very topic: #7218 You can follow its progress, see my comment to the existing proposal, and comment there! Since that PR is already open and being worked on for this very thing, I will close this PR. But I encourage you to participate in the other PR! I have a proposed suggestion for the author, and have been waiting to hear back. Would be happy to have your thoughts there. |
Description (required)
When trying to implement the dual themes of Shiki, it's necessary to use the CSS snippets that their docs provided. But because of how Astro implements the Shiki under the hood, it's necessary to use the class
.astro-codeinstead of.shikithat their docs stated.I'm proposing a new section in the Syntax highlighting of Astro docs to make clear to new users how to implement the feature of dual theming. I think that dark/light mode is a key feature and having this new section would make everything clear with Shiki.
The correct CSS to make the CSS dual theme work should be
Related issues & labels (optional)