Skip to content

i18n(ko-KR): update install-and-setup.mdx#8520

Merged
yanthomasdev merged 7 commits into
withastro:mainfrom
jsparkdev:install-and-setup
Jun 15, 2024
Merged

i18n(ko-KR): update install-and-setup.mdx#8520
yanthomasdev merged 7 commits into
withastro:mainfrom
jsparkdev:install-and-setup

Conversation

@jsparkdev
Copy link
Copy Markdown
Member

@jsparkdev jsparkdev commented Jun 14, 2024

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 15, 2024 0:26am

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 14, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 14, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko install-and-setup.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

yanthomasdev
yanthomasdev reviewed Jun 14, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jsparkdev, after fixing the headings here, LGTM

Comment thread src/content/docs/ko/install-and-setup.mdx Outdated
Comment thread src/content/docs/ko/install-and-setup.mdx Outdated
jsparkdev and others added 3 commits June 14, 2024 20:43
@jsparkdev @yanthomasdev
Update src/content/docs/ko/install-and-setup.mdx
d2c5c76 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@jsparkdev @yanthomasdev
Update src/content/docs/ko/install-and-setup.mdx
ede0693 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@jsparkdev @yanthomasdev
Update src/content/docs/ko/install-and-setup.mdx
214b107 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@yanthomasdev
Copy link
Copy Markdown
Member

yanthomasdev commented Jun 14, 2024

Thanks @jsparkdev, could you take a look at the conflict in the PR and fix accordingly? 🙌

@jsparkdev
Copy link
Copy Markdown
Member Author

jsparkdev commented Jun 15, 2024

Thanks for the good point! I fixed the crash, but I'm not sure if it worked :)

yanthomasdev
yanthomasdev approved these changes Jun 15, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work!

@yanthomasdev yanthomasdev merged commit f878c68 into withastro:main Jun 15, 2024
@jsparkdev jsparkdev deleted the install-and-setup branch June 15, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsparkdev @astrobot-houston @yanthomasdev