Skip to content

Add sentence for paginate() prev/next url when using base paths.#8569

Merged
kevinzunigacuellar merged 3 commits into
mainfrom
paginate-base
Jun 20, 2024
Merged

Add sentence for paginate() prev/next url when using base paths.#8569
kevinzunigacuellar merged 3 commits into
mainfrom
paginate-base

Conversation

@kevinzunigacuellar
Copy link
Copy Markdown
Member

@kevinzunigacuellar kevinzunigacuellar commented Jun 19, 2024

Description (required)

Add sentence for paginate() prev/next url when using base paths.

Related issues & labels (optional)

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 4:45pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 20, 2024 4:45pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 19, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/api-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

at-the-vr
at-the-vr approved these changes Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@at-the-vr at-the-vr added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 19, 2024
sarah11918
sarah11918 reviewed Jun 19, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this helpful addition @kevinzunigacuellar ! I don't know why your check is failing (haven't looked, but you can figure it out), and just left a suggestion below (if you take it, apply it in both places) 🥳

Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) and removed Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 19, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jun 19, 2024

Reran the check and it worked fine! 🥳

kevinzunigacuellar
kevinzunigacuellar commented Jun 20, 2024
View reviewed changes
Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
@kevinzunigacuellar @sarah11918
Apply suggestions from code review
a8b2b75 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@kevinzunigacuellar
Copy link
Copy Markdown
Member Author

kevinzunigacuellar commented Jun 20, 2024

Thanks for the review @at-the-vr and @sarah11918.

@kevinzunigacuellar kevinzunigacuellar merged commit f0be261 into main Jun 20, 2024
@kevinzunigacuellar kevinzunigacuellar deleted the paginate-base branch June 20, 2024 16:48
@jsparkdev jsparkdev mentioned this pull request Jun 21, 2024
Merged
@kevinzunigacuellar kevinzunigacuellar mentioned this pull request Jun 25, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Jul 22, 2024
Merged
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

+1 more reviewer

@at-the-vr at-the-vr at-the-vr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feedback-improvement Response to widget/Discord feedback improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kevinzunigacuellar @astrobot-houston @sarah11918 @at-the-vr