Skip to content

add hint regarding style and script tag locations in layout components#8621

Merged
sarah11918 merged 4 commits into
withastro:mainfrom
Trombach:main
Jun 21, 2024
Merged

add hint regarding style and script tag locations in layout components#8621
sarah11918 merged 4 commits into
withastro:mainfrom
Trombach:main

Conversation

@Trombach
Copy link
Copy Markdown
Contributor

@Trombach Trombach commented Jun 21, 2024

Description (required)

This PR adds a paragraph to the layout component page, explaining how <script> and <style> tags should be included in a component containing an <html> shell.

Related issues & labels (optional)

Discord: lukets4328

@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 21, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 21, 2024 3:11pm

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 21, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 21, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/layouts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sarah11918
sarah11918 reviewed Jun 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fabulous @Trombach ! Nicely done. I just touched up some wording, and link formatting, which I'll commit here then we can officially welcome you to Team Docs! 🥳

Comment thread src/content/docs/en/basics/layouts.mdx Outdated
Comment thread src/content/docs/en/basics/layouts.mdx
</article>
<Footer />
</body>
<style>
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMRT! 🙌

@sarah11918 sarah11918 added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 21, 2024
@sarah11918 sarah11918 merged commit c40ede5 into withastro:main Jun 21, 2024
@jsparkdev jsparkdev mentioned this pull request Jun 21, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jun 24, 2024
Merged
@Trombach Trombach mentioned this pull request Jun 25, 2024
Merged
@sarah11918 sarah11918 added the feedback-improvement Response to widget/Discord feedback label Aug 14, 2024
@vrabe vrabe mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

Assignees

No one assigned

Labels

feedback-improvement Response to widget/Discord feedback improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add documentation regarding usage of style tags in components containing html tags (i.e. layout components)

3 participants

@Trombach @astrobot-houston @sarah11918