Skip to content

i18n(fr): Add some references files and reference/integrations-reference.mdx#8691

Merged
yanthomasdev merged 27 commits into
withastro:mainfrom
thomasbnt:i18n-fr-add-reference-errors-26062024
Jul 2, 2024
Merged

i18n(fr): Add some references files and reference/integrations-reference.mdx#8691
yanthomasdev merged 27 commits into
withastro:mainfrom
thomasbnt:i18n-fr-add-reference-errors-26062024

Conversation

thomasbnt added 12 commits June 26, 2024 13:36
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
…e.mdx`

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Jun 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jul 2, 2024 3:20pm

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 26, 2024
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 26, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr reference/adapter-reference.mdx Localization changed, will be marked as complete.
fr reference/directives-reference.mdx Localization changed, will be marked as complete.
fr reference/errors/actions-without-server-output-error.mdx Localization added, will be marked as complete.
fr reference/errors/env-invalid-variable.mdx Localization added, will be marked as complete.
fr reference/errors/env-invalid-variables.mdx Localization added, will be marked as complete.
fr reference/errors/env-unsupported-get-secret.mdx Localization added, will be marked as complete.
fr reference/errors/expected-not-esmimage.mdx Localization added, will be marked as complete.
fr reference/errors/i18n-no-locale-found-in-path.mdx Localization added, will be marked as complete.
fr reference/errors/invalid-rewrite404.mdx Localization added, will be marked as complete.
fr reference/errors/no-client-entrypoint.mdx Localization changed, will be marked as complete.
fr reference/errors/prerender-client-address-not-available.mdx Localization added, will be marked as complete.
fr reference/errors/rewrite-encountered-an-error.mdx Localization added, will be marked as complete.
fr reference/errors/rewrite-with-body-used.mdx Localization added, will be marked as complete.
fr reference/errors/server-only-module.mdx Localization added, will be marked as complete.
fr reference/integrations-reference.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasbnt, this was a huge one! I noted:

  • some missing translations in the errors references (mainly anchors in see also).
  • a bullet point issue, some typo and some rewording suggestions in integrations-reference.

Also I think each heading should be capitalized, so all the option ... headings should be updated.

And Github actions detect some broken links (anchors) in integrations-reference.

Otherwise, the rest looks good!

Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/actions-without-server-output-error.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/prerender-client-address-not-available.mdx Outdated
Comment thread src/content/docs/fr/reference/errors/server-only-module.mdx Outdated
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

Thanks @thomasbnt, this was a huge one! I noted:

  • some missing translations in the errors references (mainly anchors in see also).
  • a bullet point issue, some typo and some rewording suggestions in integrations-reference.

Also I think each heading should be capitalized, so all the option ... headings should be updated.

And Github actions detect some broken links (anchors) in integrations-reference.

Otherwise, the rest looks good!

Thanks for your review!

Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thomasbnt! Almost good to go! 🚀
You have missed one anchor + my comment update and I missed 3 non-translated comments the last time... There is also the Renderers case. I'm not sure about the right term to use. Feel free to ignore my suggestion if you have another idea!

Comment thread src/content/docs/fr/reference/errors/prerender-client-address-not-available.mdx Outdated
Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
Signed-off-by: Thomas Bonnet <thomasbnt@protonmail.com>
@thomasbnt
Copy link
Copy Markdown
Member Author

Hello @ArmandPhilippot, thanks for reviewed!

Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thomasbnt Only one small change then it will be good to me!

Comment thread src/content/docs/fr/reference/integrations-reference.mdx Outdated
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀 Thanks @thomasbnt!

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@yanthomasdev yanthomasdev merged commit 3eb3af1 into withastro:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants