Update GitLab Pages deployment guide#8811
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Thank you @menghif for testing deployment and adding helpful information to the docs! So that I can better review the deploy preview, could you please make the following changes first:
Thank you again, this contribution is very helpful! After you make these changes, I'll read through it again and look closely for any typos or small fixes etc.! |
|
Hi @sarah11918, thank you for the feedback! I can definitely make all those changes. I thought I would separate Let me know if this information changes anything on how I should rewrite the page. |
|
Just to clarify what you mean: they are not needed, but if you have set them, this is how they work? If they're not needed then I'm not sure why they are included here at all. Can you explain more about why you added them here, and what you mean when you say you tested them? |
Add missing details, fix errors.
|
The The I understand the logic of putting |
|
Thanks! I added a couple of more questions calling out specific content because I'm worried this may have been just taken from GitHub, which works differently from most other hosts. We went through a LOT of careful pain figuring out exactly what was needed for GitHub pages, and we haven't had similar comments/complaints about GitLab. So I just want to be EXTRA sure that we are not overcopying and using GitHub as a kind of general model... because from our experience, GitHub pages has been anything but typical! 😂 |
sarah11918
left a comment
There was a problem hiding this comment.
Thank you so much @menghif for your patience and attention to detail here! We really appreciate having updated content that works! Welcome to Team Docs! 🥳
See #8811 Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Description (required)
This PR improves the Deploy your Astro Site to GitLab Pages guide in the following ways:
titleanddifffeatures for code blocks.siteandbasefrom the main deployment steps and add more information about the two options (similar to the "Deploy to GitHub Pages" Guide)..gitignorechanges for the build output folder.I tested deployments on Gitlab.com with a repository under my profile and another one under a group.
Related issues & labels (optional)