Link the Fontsource docs for Preloading Fonts in the Fonts page#9045
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for adding this helpful resource @vivitt ! I think many people are interested in information about preloading fonts and will appreciate this.
I think it could be even better if there could be a one-sentence introduction, though. Right now, we haven't said anything about preloading fonts, so it feels like a bit out of nowhere. ("What is this? Why do I want to know about this?)
Would you like to try to add one short sentence before this sentence to introduce the concept? A "To speed up rendering time, you may wish to preload your fonts...." or "Preloading your fonts can help make the page visible to your readers sooner."...
Think about WHY you would use preloading, and make it a "warm up" sentence for the link that provides a bridge between "We just added a font" and "here's a thing you might want to do now after that."
What do you think?
|
Hello @sarah11918, |
sarah11918
left a comment
There was a problem hiding this comment.
Looks great, thank you @vivitt ! Welcome to Team Docs! 🥳
Apply changes from withastro#9045
Apply changes from #9045 Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Description (required)
Adds a link in the Using Fontsource section of the Fonts page referencing the Fontsource docs' Preloading Fonts guide.
Related issues & labels (optional)
Excited to share my first contribution to Astro Docs 🎉 My Astro Discord username is _vivitt