Skip to content

Link the Fontsource docs for Preloading Fonts in the Fonts page#9045

Merged
liruifengv merged 4 commits into
withastro:mainfrom
vivitt:add/link-font-preload-guide
Aug 13, 2024
Merged

Link the Fontsource docs for Preloading Fonts in the Fonts page#9045
liruifengv merged 4 commits into
withastro:mainfrom
vivitt:add/link-font-preload-guide

Conversation

@vivitt
Copy link
Copy Markdown
Contributor

@vivitt vivitt commented Aug 8, 2024

Description (required)

Adds a link in the Using Fontsource section of the Fonts page referencing the Fontsource docs' Preloading Fonts guide.

Related issues & labels (optional)

Excited to share my first contribution to Astro Docs 🎉 My Astro Discord username is _vivitt

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 8, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e5dd222
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66baffd2d6211f0009a2de26
😎 Deploy Preview https://deploy-preview-9045--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 8, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/fonts.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this helpful resource @vivitt ! I think many people are interested in information about preloading fonts and will appreciate this.

I think it could be even better if there could be a one-sentence introduction, though. Right now, we haven't said anything about preloading fonts, so it feels like a bit out of nowhere. ("What is this? Why do I want to know about this?)

Would you like to try to add one short sentence before this sentence to introduce the concept? A "To speed up rendering time, you may wish to preload your fonts...." or "Preloading your fonts can help make the page visible to your readers sooner."...

Think about WHY you would use preloading, and make it a "warm up" sentence for the link that provides a bridge between "We just added a font" and "here's a thing you might want to do now after that."

What do you think?

Comment thread src/content/docs/en/guides/fonts.mdx Outdated
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Aug 8, 2024
@vivitt
Copy link
Copy Markdown
Contributor Author

vivitt commented Aug 8, 2024

Hello @sarah11918,
Thanks for your quick feedback!
Your suggestions make a lot of sense. I’ve just added one more commit including both changes. Let me know what you think and if you see anything else that can be improved.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you @vivitt ! Welcome to Team Docs! 🥳

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 12, 2024
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's ship it! 🚀

@liruifengv liruifengv merged commit ca6eb70 into withastro:main Aug 13, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 13, 2024
dreyfus92 added a commit that referenced this pull request Aug 13, 2024
Apply changes from #9045

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@vivitt vivitt deleted the add/link-font-preload-guide branch August 18, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Guide on font preloading

4 participants