feat: astro:env stable#9160
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
left a comment
There was a problem hiding this comment.
Quick initial review.. I didn't realized until I opened this up that it wasn't exactly ready for a review yet. 😅
See my comment below re: just reusing the material we already have, then working from there!
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
@sarah11918 I added a bunch of content but I'm really unsure about how to structure things, would love your guidance! |
|
Hey @florian-lefebvre , I'll be looking at this more closely today, but just pointing out that some of this content should end up in reference pages and NOT crammed all in here, which is more of a guide page. As an example, see what I'm suggesting in #9133 - the guide content doesn't have to spell things out like an API reference (and shouldn't, because then we're duplicating content and our work!). Rather, it tells the story around using this and links to references where all the details of the items are kept. So that's my first piece of advice, keep this for people learning about/setting this up for the first time, or coming back to confirm general usage, not looking up values etc. And then we'll link to each item's reference location if they need to e.g. confirm types etc. |
|
@sarah11918 tried my best to improve things! |
|
Just noting that I removed changes from the upgrade guide because I've already been working on that separately! This should also resolve conflicts on the environment variables page, so we can start fresh with that one! |
|
Hey @florian-lefebvre ! I committed an editing pass here that I think might be a more helpful organization structure? For example, the stuff about how to actually set values for environment variables was inside "Support for Vite" and you're gonna need to set these variables when using So I tried to envision a flow for the entire page that is like;
So see what you think about this, and tell me where / how it doesn't work so we can iterate on it! |
|
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
left a comment
There was a problem hiding this comment.
I think we're finally happy with this????
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
left a comment
There was a problem hiding this comment.
Actually, realizing this can be merged now because the link to #envschema shouldn't break! It just won't have the information promised to be there yet. until the core PR is merged. 😄
http://localhost:4321/en/guides/environment-variables/
Description (required)
Related issues & labels (optional)