Skip to content

Adds Hosted Media / DAM section to Content Management section#9182

Merged
sarah11918 merged 12 commits into
withastro:mainfrom
colbyfayock:add/image-content-stubs
Aug 23, 2024
Merged

Adds Hosted Media / DAM section to Content Management section#9182
sarah11918 merged 12 commits into
withastro:mainfrom
colbyfayock:add/image-content-stubs

Conversation

@colbyfayock
Copy link
Copy Markdown
Contributor

Description (required)

Based on conversations from Discord, adds a Hosted Media / DAM section to the Managing Your Content section of the Astro docs.

The content was largely based on the CMS content.

This also adds Cloudinary as the starting option with stubbed out content as I separately work towards building an integration and can additionally provide more details about how to use Cloudinary with Astro (or others from my team)

Related issues & labels (optional)

Discord username: colbyfayock

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 23, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 866f19d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66c8e4869b20500008ae473a
😎 Deploy Preview https://deploy-preview-9182--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 23, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/media.mdx Source added, will be tracked.
en guides/media/cloudinary.mdx Source added, will be tracked.
en nav.ts Source changed, localizations will be marked as outdated.
en ui.ts Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Comment thread src/i18n/en/nav.ts Outdated
key: 'guides/content-collections',
},
{ text: 'Connect a CMS', slug: 'guides/cms', key: 'guides/cms' },
{ text: 'Connect Hosted Media or DAM', slug: 'guides/media', key: 'guides/media' },
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 Aug 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking about this going under Assets actually! What do you think? Seems like maybe it should be where we discuss images etc?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah makes sense to me! i misunderstood and thought we were relating it to the content section

the only thing ot think about in the future could be video? but no reason that couldn't just fall in somewhere there still under Assets similar to how Image itself is set up 🤷

pushign that change

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty DAM awesome, @colbyfayock ! 😄

I just did some light editing, and I envisioned this page living in the Assets section near images. Any reason not to do that? If you were looking for this content, would you expect to see it in the section with Markdown/CMS stuff?

Comment thread src/content/docs/en/guides/media.mdx Outdated
Comment thread src/content/docs/en/guides/media.mdx Outdated
Comment thread src/content/docs/en/guides/media.mdx Outdated
Comment thread src/content/docs/en/guides/media.mdx Outdated
Comment thread src/content/docs/en/guides/media.mdx Outdated
Comment thread src/content/docs/en/guides/media.mdx Outdated
@sarah11918 sarah11918 changed the title [i18nIgnore] Adds Hosted Media / DAM section to Content Management section Adds Hosted Media / DAM section to Content Management section Aug 23, 2024
@sarah11918
Copy link
Copy Markdown
Member

Just updated the title because we DO want our translation system to find these new pages and translate them! 🙌

Comment thread src/content/docs/en/guides/media/cloudinary.mdx Outdated
colbyfayock and others added 2 commits August 23, 2024 14:15
@colbyfayock
Copy link
Copy Markdown
Contributor Author

yeah id say the only differentiator in my mind is assets as content vs assets as delivery, but there's no reason that can't be under Assets as you suggest. it also may not be a difference people actually think about unless they work in the space like i do. moved it under Assets!

sounds good about the title, i misread/misunderstood the translation instructions 🙃

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @colbyfayock, this looks great. Just a small nit and I believe we're good to go 🙌

Comment thread src/content/docs/en/guides/media.mdx Outdated
yanthomasdev and others added 2 commits August 23, 2024 15:24
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@colbyfayock
Copy link
Copy Markdown
Contributor Author

thank you both for the review!

@sarah11918
Copy link
Copy Markdown
Member

Realizing I've just got a bit more infra to do here!

  • making sure that the correct nav item in the sidebar is highlighted when on a media page
  • adding the media nav to all the individual media pages

@colbyfayock
Copy link
Copy Markdown
Contributor Author

apologies for missing those, thank you!

@sarah11918
Copy link
Copy Markdown
Member

It's a bit of a system! I wouldn't expect you to catch those, and even I go hunting for adding a new category like this. It's certainly not something even we do very often, and certainly not something someone else tries to do very often at all!

Comment thread src/content/docs/en/guides/media.mdx Outdated
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. site improvement Some thing that improves the website functionality - ask @delucis for help! labels Aug 23, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so excited @colbyfayock ! Thank you SO MUCH for taking the time to contribute this brand new category! I am prepared to be innundated with new stubs and resources now!

We really appreciate this, and are thrilled to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 merged commit 9589781 into withastro:main Aug 23, 2024
@colbyfayock colbyfayock deleted the add/image-content-stubs branch August 23, 2024 20:12
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Aug 23, 2024
This was referenced Aug 24, 2024
@vrabe vrabe mentioned this pull request Aug 24, 2024
dreyfus92 added a commit that referenced this pull request Aug 24, 2024
* i18n(fr): add guides/media & guides/media/cloudinary

Add new pages and nav item from #9182

* i18n(fr): reword bouchons to ébauches

---------

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. site improvement Some thing that improves the website functionality - ask @delucis for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants