Update tutorial unit 4 by giving more explanation on h1 style in about.astro page#9271
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
left a comment
There was a problem hiding this comment.
Hi @andrzeij ! Thanks for taking the time to provide feedback on the tutorial! You're right that this is something that people may encounter, and I have a suggestion below for the action I'd suggest. Let me know what you think!
sarah11918
left a comment
There was a problem hiding this comment.
Thank you again @andrzeij for contributing this! I just suggested what I think I would suggest to our new users in the tutorial as a remedy that I think is simpler and requires less explanation of how to do it.
We appreciate you taking the time to contribute and are happy to welcome you to Team Docs! 🥳
Add changes from withastro#9271
* i18n(fr): update `tutorial/4-layouts/1.mdx` Add changes from #9271 * i18n(fr): rephrase to remove redundancy In summary: `mise en page de page` > `mise en page` with some rephrasing around. * i18n(fr): small reword `à` > `dans` It's a file (implicitly) so we should use `dans` and not `à`. * i18n(fr): fix small careless mistakes... --------- Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
…about.astro
Description (required)
For tutorial unit 4, it doesn't explain much about the effect of refactoring the about.astro page that it will replaces the local h1 style with h1 style from the BaseLayout. The visual cue is that the existing h1 colour is purple, but by applying the changes suggested in the tutorial will change the h1 colour to black.
So I am suggesting to add the following note at Line 142:
(Note: using the BaseLayout to render your
about.astropage means you will lose the style for h1. If you want to keep the h1 style, you need to pass the h1 style to BaseLayout as props via component attribute.)Related issues & labels (optional)
Yes, first time contributor. Please help me with any suggestion to make it better, thank you.
Discord username: andrzeij