Skip to content

Update tutorial unit 4 by giving more explanation on h1 style in about.astro page#9271

Merged
sarah11918 merged 4 commits into
withastro:mainfrom
andrzeij:tutorial
Sep 5, 2024
Merged

Update tutorial unit 4 by giving more explanation on h1 style in about.astro page#9271
sarah11918 merged 4 commits into
withastro:mainfrom
andrzeij:tutorial

Conversation

@andrzeij
Copy link
Copy Markdown
Contributor

…about.astro

Description (required)

For tutorial unit 4, it doesn't explain much about the effect of refactoring the about.astro page that it will replaces the local h1 style with h1 style from the BaseLayout. The visual cue is that the existing h1 colour is purple, but by applying the changes suggested in the tutorial will change the h1 colour to black.

So I am suggesting to add the following note at Line 142:
(Note: using the BaseLayout to render your about.astro page means you will lose the style for h1. If you want to keep the h1 style, you need to pass the h1 style to BaseLayout as props via component attribute.)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

Yes, first time contributor. Please help me with any suggestion to make it better, thank you.

Discord username: andrzeij

@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 30, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9d6c603
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66da01d01fb58800088ae56e
😎 Deploy Preview https://deploy-preview-9271--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 30, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en tutorial/4-layouts/1.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @andrzeij ! Thanks for taking the time to provide feedback on the tutorial! You're right that this is something that people may encounter, and I have a suggestion below for the action I'd suggest. Let me know what you think!

Comment thread src/content/docs/en/tutorial/4-layouts/1.mdx Outdated
@sarah11918 sarah11918 added the tutorial Content/UI for the Build a Blog Tutorial label Sep 3, 2024
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again @andrzeij for contributing this! I just suggested what I think I would suggest to our new users in the tutorial as a remedy that I think is simpler and requires less explanation of how to do it.

We appreciate you taking the time to contribute and are happy to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 merged commit c852e64 into withastro:main Sep 5, 2024
ArmandPhilippot added a commit to ArmandPhilippot/astro-docs that referenced this pull request Sep 5, 2024
yanthomasdev added a commit that referenced this pull request Sep 5, 2024
* i18n(fr): update `tutorial/4-layouts/1.mdx`

Add changes from #9271

* i18n(fr): rephrase to remove redundancy

In summary: `mise en page de page` > `mise en page` with some
rephrasing around.

* i18n(fr): small reword `à` > `dans`

It's a file (implicitly) so we should use `dans` and not `à`.

* i18n(fr): fix small careless mistakes...

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@andrzeij andrzeij deleted the tutorial branch September 16, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tutorial Content/UI for the Build a Blog Tutorial

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants