[mdx] remove mention of layout frontmatter property#9474
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Alright, I think I got everything worked out! |
|
!coauthor |
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Sorry about earlier, I just replied quickly before logging out!
Rereading the page, I think that maybe I'm being too picky sometimes... Other examples on the page use MDX files in src/pages without a layout, so the path could have remained the same. I probably thought about importing a Layout because we were in "Using Components in MDX".
(Anyway, thanks for the update! I still think it makes more sense for newcomers... Use MDX as a page without adding a layout, you have to like minimalism! 😅)
At least the highlighting is correct now! 😄
|
Thanks! I'll go with this for now! Appreciate the help and attention to detail! |
|
gah, now I want to update the rest of them... |
|
Alright, are you up for one last check @ArmandPhilippot ??? |
See #9474 Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Description (required)
This removes mention of the frontmatter
layoutproperty available to MDX files from the MDX page so we can consolidate all mention of it to the Layouts page itself.As we are not sure how much we want to promote this, leaving it to the Layouts page still makes the information prominently available without encouraging/assuming its use. Importing and using an Astro component as a layout is a more flexible option than the "magic" special property, so it will be easier to mention any limitations and caveats in just one place.
Related issues & labels (optional)
While this PR itself isn't exactly what the issue asked for, I do think a few recent changes to this, the layouts and the markdown pages all combined will work together to prevent people trying to use named slots in MDX with the special frontmatter property.