Skip to content

i18n(de): update translation i18n/de/nav.ts#9686

Merged
yanthomasdev merged 8 commits into
withastro:mainfrom
trueberryless:i18n-nav
Oct 18, 2024
Merged

i18n(de): update translation i18n/de/nav.ts#9686
yanthomasdev merged 8 commits into
withastro:mainfrom
trueberryless:i18n-nav

Conversation

@trueberryless
Copy link
Copy Markdown
Contributor

@trueberryless trueberryless commented Oct 15, 2024

Description

Translation of i18n/de/nav.ts into German language.

@netlify
Copy link
Copy Markdown

netlify Bot commented Oct 15, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 8840fe9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6712d3d07fecdf000861884f
😎 Deploy Preview https://deploy-preview-9686--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 15, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 15, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de nav.ts Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

hippotastic
hippotastic reviewed Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@hippotastic hippotastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR! I added some German feedback to a few points. Very solid work overall, thank you!

Comment thread src/i18n/de/nav.ts Outdated
Comment thread src/i18n/de/nav.ts Outdated
Comment thread src/i18n/de/nav.ts Outdated
Comment thread src/i18n/de/nav.ts Outdated
Comment thread src/i18n/de/nav.ts Outdated
Comment thread src/i18n/de/nav.ts Outdated
trueberryless and others added 6 commits October 18, 2024 23:01
@trueberryless @hippotastic
Update src/i18n/de/nav.ts
edd9c3a 
Co-authored-by: Hippo <6137925+hippotastic@users.noreply.github.com>
@trueberryless @hippotastic
Update src/i18n/de/nav.ts
43c27be 
Co-authored-by: Hippo <6137925+hippotastic@users.noreply.github.com>
@trueberryless @hippotastic
Update src/i18n/de/nav.ts
5d6df8e 
Co-authored-by: Hippo <6137925+hippotastic@users.noreply.github.com>
@trueberryless @hippotastic
Update src/i18n/de/nav.ts
a8134de 
Co-authored-by: Hippo <6137925+hippotastic@users.noreply.github.com>
@trueberryless @hippotastic
Update src/i18n/de/nav.ts
2850212 
Co-authored-by: Hippo <6137925+hippotastic@users.noreply.github.com>
@trueberryless
Update nav.ts
f52a0e4
@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Oct 18, 2024

@hippotastic Kannst du intern gleich auch sagen, dass reference/components-reference, also die Built-in components wahrscheinlich mit i18nIgnore durchgeführt wurden, weil auch zB bei koreanisch die nicht drinnen ist, obwohls auf der tracker seite vollständig ist

@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Oct 18, 2024

btw, ist intern der astro discord?

wenn ja, darf ich bitte wissen welcher channel?

@trueberryless
Copy link
Copy Markdown
Contributor Author

trueberryless commented Oct 18, 2024

Yeah, found it: #9465

not sure why they did it with i18nIgnore, have to look further into it...

@hippotastic
Copy link
Copy Markdown
Contributor

hippotastic commented Oct 18, 2024 •
edited
Loading

btw, ist intern der astro discord?

wenn ja, darf ich bitte wissen welcher channel?

Haha, ja, ist auf Discord, und ich hab im französischen Übersetzungs-Thread Bescheid gesagt. Also hier: https://discord.com/channels/830184174198718474/971729943786561556

hippotastic
hippotastic approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@hippotastic hippotastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yanthomasdev
yanthomasdev approved these changes Oct 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work! 🙌

@yanthomasdev yanthomasdev merged commit ae1107e into withastro:main Oct 18, 2024
@hippotastic
Copy link
Copy Markdown
Contributor

hippotastic commented Oct 18, 2024

Yeah, found it: #9465

not sure why they did it with i18nIgnore, have to look further into it...

Thanks for investigating, great find! We'll take care of this and fix it.

@trueberryless trueberryless deleted the i18n-nav branch October 19, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

+1 more reviewer

@hippotastic hippotastic hippotastic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@trueberryless @astrobot-houston @hippotastic @yanthomasdev